Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): add rw_epoch_to_ts #19473

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(expr): add rw_epoch_to_ts #19473

merged 1 commit into from
Nov 21, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Nov 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

original motivation: Can only see createdAtEpoch on dashboard, so came up with the idea of exposing this function

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan force-pushed the xxchan/various-lobster branch from 72d7b77 to 140dbd0 Compare November 20, 2024 09:50
@xxchan xxchan requested review from stdrc and BugenZhao November 20, 2024 09:50
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems equivalent to proctime with explicitly specified epoch. Reminds me of rw_vnode in batch vs streaming mode.

@xxchan xxchan added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 1eb4ce0 Nov 21, 2024
30 of 31 checks passed
@xxchan xxchan deleted the xxchan/various-lobster branch November 21, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants